[#20] Support .mjs and .cjs file extension #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marco-prontera
requested changes
Apr 16, 2022
|
@cdauth The new version is published! Thanks for the collaboration 👍 |
|
That was fast, thank you! |
marco-prontera
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am publishing my ESM bundle with a
.mjsfile extension. My understanding of vitejs/vite#6827 is that this will become the default in Library Mode to ensure compatibility with Node.js.Currently,
vite-plugin-css-injected-by-jsonly injects CSS into files whose file name contains.js. This pull request changes the behaviour to inject CSS into files whose file name ends with.js,.cjsor.mjs.If you have time, it would be nice if you could publish a new release including this change, as I am currently blocked by this in migrating my project to Vite. Thank you for this useful plugin!