Fix for determining Desktop Safari version, improve code readability #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
npx browserslist-to-esbuild 'supports css-grid'results inchrome57 edge12 firefox52 ie10 ios10.3 opera44 safari17.3.The desktop Safari version should be 10.1. See https://browsersl.ist/#q=supports+css-grid.
The source of the bug is the assumption at this line that the older version is always last in the array that
browserslist()returns. For Safari,Safari TPis last in the array.I think this test should be removed. I don't see why anyone would care about Safari TP in a browserslist query. Maybe I'm missing something?
Safari TP is already handled by this line.