Skip to content

Commit

Permalink
fix: TableHeaderCell design fixes (microsoft#25712)
Browse files Browse the repository at this point in the history
* fix: TableHeaderCell design fixes

- Sort arrow is 12px
- Sort arrow has a xxs top padding for alignment
- Gap between header text and sort icon is xs

* changefile

* revert unnecessary
  • Loading branch information
ling1726 authored Nov 22, 2022
1 parent f1a66a8 commit dfe4306
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 3 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "prerelease",
"comment": "fix: TableHeaderCell design fixes",
"packageName": "@fluentui/react-table",
"email": "[email protected]",
"dependentChangeType": "patch"
}
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ import { useTableContext } from '../../contexts/tableContext';
import { useARIAButtonShorthand } from '@fluentui/react-aria';

const sortIcons = {
ascending: <ArrowUpRegular />,
descending: <ArrowDownRegular />,
ascending: <ArrowUpRegular fontSize={12} />,
descending: <ArrowDownRegular fontSize={12} />,
};

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ const useStyles = makeStyles({
flexGrow: 1,
height: '100%',
alignItems: 'center',
...shorthands.gap(tokens.spacingHorizontalS),
...shorthands.gap(tokens.spacingHorizontalXS),
minHeight: '32px',
...shorthands.flex(1, 1, '0px'),
},
Expand All @@ -74,6 +74,7 @@ const useStyles = makeStyles({
sortIcon: {
display: 'flex',
alignItems: 'center',
paddingTop: tokens.spacingVerticalXXS,
},
});

Expand Down

0 comments on commit dfe4306

Please sign in to comment.