You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Both the KeycloakOpenID class as well as the KeycloakAdmin class (and subsequently also the ConnectionManager and KeycloakOpenIDConnection support a verify parameter which defines whether the SSL certificate should be checked. Currently, this is specified as being a boolean value.
That parameter is then subsequently passed to requestsSession methods like get and put. According to the requestsAPI description, this verify parameter actually accepts a boolean value or a string, in which case the value must be a path to a custom CA file used for certificate validation.
Passing a string works already today as the parameter is not validated and passed straight to the requests methods. I suggest updating the documentation and make clear that both a boolean value or a string can be passed.
This discussion came up during a MR on my own library making use of yours. See the following discussion for more details.
The text was updated successfully, but these errors were encountered:
Both the
KeycloakOpenID
class as well as theKeycloakAdmin
class (and subsequently also theConnectionManager
andKeycloakOpenIDConnection
support averify
parameter which defines whether the SSL certificate should be checked. Currently, this is specified as being a boolean value.That parameter is then subsequently passed to
requests
Session
methods likeget
andput
. According to therequests
API description, this verify parameter actually accepts a boolean value or a string, in which case the value must be a path to a custom CA file used for certificate validation.Passing a string works already today as the parameter is not validated and passed straight to the
requests
methods. I suggest updating the documentation and make clear that both a boolean value or a string can be passed.This discussion came up during a MR on my own library making use of yours. See the following discussion for more details.
The text was updated successfully, but these errors were encountered: