Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the verify attribute to be bool or string #479

Closed
waza-ari opened this issue Aug 24, 2023 · 0 comments
Closed

Allow the verify attribute to be bool or string #479

waza-ari opened this issue Aug 24, 2023 · 0 comments

Comments

@waza-ari
Copy link
Contributor

Both the KeycloakOpenID class as well as the KeycloakAdmin class (and subsequently also the ConnectionManager and KeycloakOpenIDConnection support a verify parameter which defines whether the SSL certificate should be checked. Currently, this is specified as being a boolean value.

That parameter is then subsequently passed to requests Session methods like get and put. According to the requests API description, this verify parameter actually accepts a boolean value or a string, in which case the value must be a path to a custom CA file used for certificate validation.

Passing a string works already today as the parameter is not validated and passed straight to the requests methods. I suggest updating the documentation and make clear that both a boolean value or a string can be passed.

This discussion came up during a MR on my own library making use of yours. See the following discussion for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants