Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pyproject.toml): loose requests pgk and remove urllib3 as dependency #434

Merged
merged 4 commits into from
Apr 28, 2023

Conversation

karimelhajoui63
Copy link
Contributor

@karimelhajoui63 karimelhajoui63 commented Apr 20, 2023

Hi,

We can see that when we install the v2.15.3 from pipenv, then print the graph of dependencies:

pipenv install python-keycloak==2.15.3
pipenv graph

we have a conflict on the urllib3 lib :

python-keycloak==2.15.3
  - deprecation [required: >=2.1.0,<3.0.0, installed: 2.1.0]
    - packaging [required: Any, installed: 23.1]
  - python-jose [required: >=3.3.0,<4.0.0, installed: 3.3.0]
    - ecdsa [required: !=0.15, installed: 0.18.0]
      - six [required: >=1.9.0, installed: 1.16.0]
    - pyasn1 [required: Any, installed: 0.5.0]
    - rsa [required: Any, installed: 4.9]
      - pyasn1 [required: >=0.1.3, installed: 0.5.0]
  - requests [required: >=2.28.2,<3.0.0, installed: 2.20.0]
    - certifi [required: >=2017.4.17, installed: 2022.12.7]
    - chardet [required: >=3.0.2,<3.1.0, installed: 3.0.4]
    - idna [required: >=2.5,<2.8, installed: 2.7]
    - urllib3 [required: >=1.21.1,<1.25, installed: 1.24.3]     # <1.25
  - requests-toolbelt [required: >=0.10.1,<0.11.0, installed: 0.10.1]
    - requests [required: >=2.0.1,<3.0.0, installed: 2.20.0]
      - certifi [required: >=2017.4.17, installed: 2022.12.7]
      - chardet [required: >=3.0.2,<3.1.0, installed: 3.0.4]
      - idna [required: >=2.5,<2.8, installed: 2.7]
      - urllib3 [required: >=1.21.1,<1.25, installed: 1.24.3]   # <1.25
  - urllib3 [required: >=1.26.14,<2.0.0, installed: 1.24.3]     # >=1.26.14

So I:

  • removed the urllib3 direct dependence, since it doesn't seem to be used in this code base
  • allowed the use of requests package starting from v2.20.0 for more compatibility with other packages

The tests aren't green, but this doesn't seem to be related with this PR since even when I revert: everything, the errors where still here.

Any info on what is going on with these latest tests ?

@karimelhajoui63 karimelhajoui63 marked this pull request as ready for review April 21, 2023 10:51
Copy link
Collaborator

@ryshoooo ryshoooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @karimelhajoui63

Thanks a lot for this change :) It's been on my todo list for a while. LGTM, the tests should now pass on the master branch :)

@ryshoooo ryshoooo merged commit 35bdbe9 into marcospereirampj:master Apr 28, 2023
NoDataIsAvailable pushed a commit to NoDataIsAvailable/python-keycloak-extended that referenced this pull request Jan 8, 2024
…ncy (marcospereirampj#434)

* fix(pyproject.toml): loose requests pgk and remove urllib3 as dependency

* build: update poetry.lock

* revert: everything

* revert: revert-ception
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants