enh: improve performance of get_user_id #449
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjeanroy
force-pushed
the
enh/improve-get-user-id
branch
from
e5f6a7a to
4a20609
Compare
NoDataIsAvailable
pushed a commit
to NoDataIsAvailable/python-keycloak-extended
that referenced
this pull request
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the performance of the
get_user_idfunction by changing how to retrieve a user from a username:usersendpoint by using the search query, which starts to be slow when you have thousands of users.usersendpoint, but it queries the endpoint by specifying the username parameter, a max of 1, and an exact, which is much faster.