Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add missing get_realm_role_by_id to KeycloakAdmin #468

Merged

Conversation

cainotis
Copy link
Contributor

Adds missing get_realm_role_by_id to KeycloakAdmin

@cainotis
Copy link
Contributor Author

I have no idea why it broken on that test, it is in a part i haven't touched

@cainotis cainotis marked this pull request as ready for review July 19, 2023 20:13
@zimaldone
Copy link
Contributor

I have no idea why it broken on that test, it is in a part i haven't touched

it's due to deprecation of HTTP CHALLENGE flow in the latest Keycloak 22.
keycloak/keycloak#20497

I also struggled a bit and I fixed in my PR (#474) in a bit naive way 😄

Copy link
Collaborator

@ryshoooo ryshoooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @cainotis!

LGTM! :)

@ryshoooo ryshoooo merged commit b93536b into marcospereirampj:master Nov 13, 2023
NoDataIsAvailable pushed a commit to NoDataIsAvailable/python-keycloak-extended that referenced this pull request Jan 8, 2024
…rampj#468)

* feat: add missing get_realm_role_by_id to KeycloakAdmin

* fix: test was using role_name instead role_id

---------

Co-authored-by: Cainã S. G <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants