Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add direct "setuptools" dependency #505

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

pehala
Copy link
Contributor

@pehala pehala commented Nov 13, 2023

With Python 3.12 the setuptools is no longer enabled by default, which makes python-keycloak fail because of pkg_resources.
Similarly with Poetry 1.7.0, the poetry install --sync also removes the setuptools, which results in the same error

I am not sure which version is reasonable to depend on, so I added any for now.

Copy link
Collaborator

@ryshoooo ryshoooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @pehala!

I'll probably set a lower bound for the version a bit later, but this is good enough for now :)

@ryshoooo ryshoooo merged commit e0e1882 into marcospereirampj:master Nov 13, 2023
NoDataIsAvailable pushed a commit to NoDataIsAvailable/python-keycloak-extended that referenced this pull request Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants