Ci/fix tests #506
Merged
Ci/fix tests #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 13, 2023
pehala
reviewed
Nov 13, 2023
pyproject.toml
Outdated
| python = ">=3.7,<4.0" | ||
| setuptools = "*" | ||
| python = ">=3.8,<4.0" | ||
| setuptools = ">=50.0.0" |
There was a problem hiding this comment.
Is it still needed if you switched to importlib, not sure if it is used somewhere else too?
There was a problem hiding this comment.
True, I don't think it is, at least nothing was failing when it was removed during my testing. Thanks, will remove :)
There was a problem hiding this comment.
Looks like babel has setuptools included anyway. But yeah, we don't explicitly need it. Removed
NoDataIsAvailable
pushed a commit
to NoDataIsAvailable/python-keycloak-extended
that referenced
this pull request
Jan 8, 2024
* chore: deps update * test: fix tests * ci: update * fix: dependencies * ci: drop python 3.7 * fix: docs, lint etc * test: fixed exchange * chore: docs lint * ci: ignore e231 * fix: upgrade sphinx * docs: read the docs updated * chore: removed setuptools
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed tests, dropped Python 3.7, updated dependencies, sanitized a bit the latest PR contributions.