Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add correct return type to get_credentials and a_get_credentials #640

Merged
merged 1 commit into from
Feb 23, 2025
Merged

fix: add correct return type to get_credentials and a_get_credentials #640

merged 1 commit into from
Feb 23, 2025

Conversation

Liambeck99
Copy link
Contributor

@Liambeck99 Liambeck99 commented Feb 21, 2025 •
edited
Loading

Hello 👋

Was using this earlier and noticed the return type on get_credentials states -> dict whereas its actually a list, as confirmed by the Keycloak API docs and also the Docstring stating a list, so thought I'd update 😄

@Liambeck99 Liambeck99 marked this pull request as ready for review February 21, 2025 21:57
ryshoooo
ryshoooo approved these changes Feb 23, 2025
View reviewed changes
Copy link
Collaborator

@ryshoooo ryshoooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Liambeck99

Thanks a lot for the fix! LGTM :)

@ryshoooo ryshoooo merged commit f9138d1 into marcospereirampj:master Feb 23, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryshoooo ryshoooo ryshoooo approved these changes

@marcospereirampj marcospereirampj Awaiting requested review from marcospereirampj marcospereirampj is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Liambeck99 @ryshoooo