Add command for new release #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, this is great - thanks! Sorry for the long delay in reacting. This patch ends up including all of package.json in every build/release. How do you feel about that? |
marcuswestin
added a commit
that referenced
this pull request
Jun 20, 2017
…into gh-218-release-script
marcuswestin
added a commit
that referenced
this pull request
Jun 20, 2017
|
Ah, sorry for the delay in responding! I think that should be fine—happy to see it merged 😊 |
|
Thanks @jrbotros! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a first stab at #199 using
npm version. Wasn’t sure if I should add a command to the Makefile or if runningnpm version patch/minor/major && npm publishwas good enough (since passing the patch/minor/major arg to a make command is a bit of a pain). I also updatedstore-engine.jsto import the version string frompackage.json, but if there’s a good reason for keeping it in two places I’m happy to retool my PR a bit!