Fix a misplaced paren from previous PR (microsoft#68)

* Fix a misplaced paren from previous PR * Add a test to prevent regressions
mariarek · Oct 16, 2018 · 1285843 · 1285843
1 parent da5a95a
commit 1285843
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 1 deletion.
diff --git a/src/SqlProviderBase.ts b/src/SqlProviderBase.ts
@@ -959,7 +959,7 @@ class SqlStore implements NoSqlProvider.DbStore {
                     const itemPageSize = Math.floor(this._trans.internal_getMaxVariables() / insertParamCount);
                     // data contains all the input parameters
                     for (let i = 0; i < (data.length / insertParamCount); i += itemPageSize) {
-                        const thisPageCount = Math.min(itemPageSize, (data.length / insertParamCount)) - i;
+                        const thisPageCount = Math.min(itemPageSize, (data.length / insertParamCount) - i);
                         const qmarksValues = _.fill(new Array(thisPageCount), generateParamPlaceholder(insertParamCount));
                         insertQueries.push(this._trans.internal_nonQuery('INSERT INTO ' +
                             this._schema.name + '_' + index.name + ' (nsp_key, nsp_refpk' + (index.includeDataInIndex ? ', nsp_data' : '') +

diff --git a/src/tests/NoSqlProviderTests.ts b/src/tests/NoSqlProviderTests.ts
@@ -729,6 +729,34 @@ describe('NoSqlProvider', function () {
                     });
                 });
 
+                // Ensure that we properly batch multi-key sql inserts
+                if (provName.indexOf('sql') !== -1) {
+                    it('MultiEntry multipart index - large index put', () => {
+                        return openProvider(provName, {
+                            version: 1,
+                            stores: [
+                                {
+                                    name: 'test',
+                                    primaryKeyPath: 'id',
+                                    indexes: [
+                                        {
+                                            name: 'key',
+                                            multiEntry: true,
+                                            keyPath: 'k.k',
+                                        }
+                                    ]
+                                }
+                            ]
+                        }, true).then(prov => {
+                            const keys: string[] = [];
+                            _.times(1000, () => {
+                                keys.push(_.uniqueId('multipartKey'));
+                            });
+                            return prov.put('test', { id: 'a', val: 'b', k: { k: keys } });
+                        });
+                    });
+                }
+
                 it('MultiEntry multipart indexed tests - Compound Key', () => {
                     return openProvider(provName, {
                         version: 1,