Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality for converting Device models to json #75

Merged
merged 4 commits into from
Apr 1, 2024

Conversation

mario-bermonti
Copy link
Owner

Description

Includes the implementation of Device.toJson(), its documentation, and an unit test for this method.

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🐞 Bug fix (non-breaking change that fixes an issue)
  • 🔧 Maintenance (non-breaking change that improves code)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix
  • 🔐 Improvements to the CI workflow

Checklist

improve: Impl Device.toJson()

improve: Add second part of Device.toJson() impl
test: Add test for Device.toJson()

doc: Remove comments from Device.toJson() test
@mario-bermonti mario-bermonti merged commit 8b14f57 into mario-bermonti/issue70 Apr 1, 2024
2 checks passed
@mario-bermonti mario-bermonti deleted the device-json branch April 1, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant