Make trickle thread-safe #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thread safety is provided by a big global lock with pthread. There is maybe ways to increase lock granularity but all I was interested in was to have a safe behavior in a threaded environment. I have modified the configure.in file so someone could fall back to the non thread-safe version with the configure script option --disable-threadsafe I have improved the AC_CHECK_TYPE macro for in_addr_t. As it was, it was causing a compiling error on my system. All the other modifs are from the fact that I did use autoconf 1.69. I had to modernize some parts of the am/in files to make them work with the latest version. Signed-off-by: Olivier Langlois <[email protected]>
|
LGTM! Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
thread safety is provided by a big global lock with pthread. There is maybe ways to increase lock
granularity but all I was interested in was to have a safe behavior in a threaded environment.
I have modified the configure.in file so
someone could fall back to the non thread-safe version with the configure script option
--disable-threadsafe
I have improved the AC_CHECK_TYPE macro for in_addr_t. As it was, it was causing a compiling
error on my system.
All the other modifs are from the fact that I did use autoconf 1.69. I had to modernize some parts
of the am/in files to make them work with the latest version.
Signed-off-by: Olivier Langlois [email protected]