Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix references to powers of ten #7

Open
markburns opened this issue Dec 2, 2015 · 2 comments
Open

fix references to powers of ten #7

markburns opened this issue Dec 2, 2015 · 2 comments

Comments

@markburns
Copy link
Owner

see https://github.com/markburns/numbers_in_words/pull/6/files#r46365729

@markburns markburns mentioned this issue Dec 3, 2015
Merged
@dimidd
Copy link
Collaborator

dimidd commented Dec 6, 2015

Right, it should be language dependent, e.g. some languages have a word for 10000, while English doesn't. How do I access the language inside the NumberParser module?

@markburns
Copy link
Owner Author

Actually, I think we should wait until we have one more language before thinking about this: once #12 is done it will be clearer which code belongs where. Otherwise we're guessing too much upfront. (Which is what I had already done when initially writing this stuff anyway).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants