Years #6
Merged
Years #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dimid Duchovny <[email protected]>
Signed-off-by: Dimid Duchovny <[email protected]>
Signed-off-by: Dimid Duchovny <[email protected]>
Signed-off-by: Dimid Duchovny <[email protected]>
Signed-off-by: Dimid Duchovny <[email protected]>
Signed-off-by: Dimid Duchovny <[email protected]>
Signed-off-by: Dimid Duchovny <[email protected]>
Signed-off-by: Dimid Duchovny <[email protected]>
Signed-off-by: Dimid Duchovny <[email protected]>
This reverts commit dbf601f.
duck punches 'num_compress' to String Signed-off-by: Dimid Duchovny <[email protected]>
Signed-off-by: Dimid Duchovny <[email protected]>
Signed-off-by: Dimid Duchovny <[email protected]>
Signed-off-by: Dimid Duchovny <[email protected]>
Signed-off-by: Dimid Duchovny <[email protected]>
Signed-off-by: Dimid Duchovny <[email protected]>
Signed-off-by: Dimid Duchovny <[email protected]>
Signed-off-by: Dimid Duchovny <[email protected]>
Signed-off-by: Dimid Duchovny <[email protected]>
This conversion is done by Transpec 3.1.1 with the following command:
transpec
* 143 conversions
from: obj.should
to: expect(obj).to
* 138 conversions
from: == expected
to: eq(expected)
* 5 conversions
from: =~ /pattern/
to: match(/pattern/)
For more details: https://github.com/yujinakayama/transpec#supported-conversions
Signed-off-by: Dimid Duchovny <[email protected]>
Signed-off-by: Dimid Duchovny <[email protected]>
Signed-off-by: Dimid Duchovny <[email protected]>
Signed-off-by: Dimid Duchovny <[email protected]>
Signed-off-by: Dimid Duchovny <[email protected]>
Signed-off-by: Dimid Duchovny <[email protected]>
+ english/canonize Signed-off-by: Dimid Duchovny <[email protected]>
Signed-off-by: Dimid Duchovny <[email protected]>
Signed-off-by: Dimid Duchovny <[email protected]>
Signed-off-by: Dimid Duchovny <[email protected]>
Signed-off-by: Dimid Duchovny <[email protected]>
Signed-off-by: Dimid Duchovny <[email protected]>
Signed-off-by: Dimid Duchovny <[email protected]>
Signed-off-by: Dimid Duchovny <[email protected]>
Signed-off-by: Dimid Duchovny <[email protected]>
Signed-off-by: Dimid Duchovny <[email protected]>
Signed-off-by: Dimid Duchovny <[email protected]>
Signed-off-by: Dimid Duchovny <[email protected]>
Signed-off-by: Dimid Duchovny <[email protected]>
Signed-off-by: Dimid Duchovny <[email protected]>
Signed-off-by: Dimid Duchovny <[email protected]>
Signed-off-by: Dimid Duchovny <[email protected]>
Signed-off-by: Dimid Duchovny <[email protected]>
| @@ -0,0 +1,54 @@ | |||
| PATH | |||
There was a problem hiding this comment.
I removed the Gemfile.lock as per http://yehudakatz.com/2010/12/16/clarifying-the-roles-of-the-gemspec-and-gemfile/
Let's not add back in
|
Thanks @dimidd all looks good. By GPA I meant https://codeclimate.com/github/markburns/numbers_in_words But it looks like your new branch was fine |
This was referenced Dec 2, 2015
Closed
|
Changes now in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.