Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepend public path to output src if present #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

amay
Copy link

@amay amay commented Jan 23, 2016

This is needed to support CDN scenarios.

This is needed to support CDN scenarios.
@amay
Copy link
Author

amay commented Jan 23, 2016

Hi Mark. Thanks for making the plugin. Let me know if there is anything else I need to do to get this merged. Cheers.

@amay
Copy link
Author

amay commented Jan 28, 2016

@markdalgleish any update on merging this? Thanks.

@phyllisstein
Copy link

Just got bit by this myself. On Android versions of Google Chrome, it seems to cause issues whether or not one uses a CDN: given a tree that includes this...

public
├── img
│   └── a5fad71f02af5c65a136d7c1954117c2.png
└── manifest-b5154266300fae0ce2ee91a1366c7325.json

...and JSON that includes this...

"icons": [
  {
    "src": "img/a5fad71f02af5c65a136d7c1954117c2.png",
    "type": "image/png",
    "sizes": "144x144"
  }
]

...Chrome shows a broken image for the relatively-referenced icon and refuses to display the app banner.

Is there any path to getting this merged in, @markdalgleish? It looks beautifully thought-out and tested, at least to my untrained eye.

@ZauberNerd
Copy link

Ping @markdalgleish could you please take a look at this and publish a new release of this loader?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants