Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not autolink a trailing "!" in a URL #1027

Closed
joshbruce opened this issue Jan 21, 2018 · 3 comments · Fixed by #1034
Closed

Do not autolink a trailing "!" in a URL #1027

joshbruce opened this issue Jan 21, 2018 · 3 comments · Fixed by #1034
Labels
category: links L1 - broken Valid usage causes incorrect output OR a crash AND there is no known workaround for the issue

Comments

@joshbruce
Copy link
Member

See #638 & #984

@joshbruce joshbruce added this to the 0.4.0 - No known defects milestone Jan 21, 2018
@joshbruce
Copy link
Member Author

Not sure how GFM and Commonmark define this as of this writing.

@Feder1co5oave
Copy link
Contributor

Here for commonmark, and here for gfm

@joshbruce joshbruce added L1 - broken Valid usage causes incorrect output OR a crash AND there is no known workaround for the issue category: links and removed question labels Jan 22, 2018
@Feder1co5oave
Copy link
Contributor

I'm working on making autolinks commonmark and gfm compliant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: links L1 - broken Valid usage causes incorrect output OR a crash AND there is no known workaround for the issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants