-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[commonmark]+[gfm] make autolinks compliant #1034
Conversation
* Expand gfm link tests to include all possible ending punctuation
test 574 does not pass because of url encoding FIXME)
…h dash or underscore
Thanks @Feder1co5oave! Seems to be failing??
|
Yep, I explained in my first post:
I actually could have edited the test case to make it pass, but I think it's time to solve this urlencoding thing so I left it as it was in commonmark. Commonmark does url encoding. |
I'm thinking Travis CI integration with this repo would be really, really convenient, since you can set it up to run at every commit on master and on every pull request submitted. That way you can run tests automatically and get immediate feedback, and you could also do linting if you will. |
Sorry, missed that. Thanks for the reiteration. Agree with the CI piece - unfortunately, I don't control that. See #967 for more details. |
[commonmark]+[gfm] make autolinks compliant
This fixes #1027 and replaces #638, fixes #842, fixes #813, fixes #859, fixes #593, fixes #890
It follows the commonmark spec and gfm extension spec.
< >
and must be absolute URIs or email addresses.< >
and can be http, https or ftp absolute URLs, URLs starting with 'www.' and email addresses.Example 574 of the cm_autolinks test fails due to encoding problems, they'll be fixed in the next PR.