anchor id's are inconsistent

[jonschlinkert]

This:

<h1>{{gist}} helper</h1>

produces:

<h1 id="-gist-helper">{{gist}} helper</h1>

For this feature to be useable, I'm resorting to regex replacements on the ID's - which is just as hacky (and almost as much work) as implementing a complete workaround.

I love marked.js, we use it extensively on assemble projects, it would be great if one of the more complete PR's for this was merged in.

[DTrejo]

hey, it is replacing the characters it can't put into the hash with dashes. I'd think the problem is with the {{ rather than the way it makes hashes. Is it like that for templating or something?

[jonschlinkert]

http://assemble.io/helpers/helpers-code.html

the problem is with the {{ rather than the way it makes hashes. Is it like that for templating or something?

Yes, it's for documentation. So the problem is with the expectation that users should only use certain characters in headings for this solution to work. And if the HTML spec allows me to put those characters in the heading, then the problem is with the overly simplistic regex being used to slugify the heading.

IMO, the implementation for headings is self-indulgent to maintain an ideal with the parser, rather than being sensitive to the needs of users. e.g. "Hey, since marked.js can only properly transform A-Z, don't use any other characters in headings and everything will be fine". I've already commented this effect here: #181 (comment)

[DTrejo]

Ah I see there is some complicated history with this feature. I shouldn't butt in ;)

[jonschlinkert]

Sorry if I came across like that. You have just as much of a right to weigh in on this as anyone else

Sent from my iPhone

On Nov 5, 2013, at 12:49 PM, David Trejo [email protected] wrote:

Ah I see there is some complicated history with this feature. I shouldn't butt in ;)

—
Reply to this email directly or view it on GitHub.

[DTrejo]

No I wasn't offended or anything don't worry.

What do you think you would like the behavior to be for this?

On Tue, Nov 5, 2013 at 10:51 AM, Jon Schlinkert [email protected]:

Sorry if I came across like that. You have just as much of a right to
weigh in on this as anyone else

Sent from my iPhone

On Nov 5, 2013, at 12:49 PM, David Trejo [email protected]
wrote:

Ah I see there is some complicated history with this feature. I
shouldn't butt in ;)

—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/278#issuecomment-27800793
.

See my projects at dtrejo.com

[jonschlinkert]

I like @ChrisWren's solution here: #181 (comment). However it's achieved I think a simple interface for custom functions would provide users with as much power and flexibility as they need. And really, I'd prefer almost any solution over having marked.js make decisions about how to attributes to my markup.

[ChrisWren]

you can now use the renderer to have custom ids