-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert 98ac7a4 and a477d1d #1007
Conversation
@Feder1co5oave: Real quick, this looks good to me, but I would like a second pair of eyes - just to be able to add it to the release we are trying to do today. Thank you @KostyaTretyak! |
NO WAIT |
Looks like this won't solve #1006. Check out my last comments. |
Now marked works this way: `
def ?`
Output: <p>`</p>
<p>def ?`</p> With this pull request marked output: <p><code>def ?</code></p> |
Three questions mainly for @KostyaTretyak, @Feder1co5oave, @UziTech:
|
I believe it's better if we just revert this one (#974), push out important security issues and in the meanwhile work on these, as you suggest @joshbruce. @KostyaTretyak I admit I'm crossing my eyes over regexes and markdown examples, can you point out in the review what complies to the spec and what doesn't? Thanks to both of you |
@Feder1co5oave: I believe that's the best as well. Having said that, still not entirely comfortable doing the revert myself using |
You only need to merge this pr |
@Feder1co5oave: Thanks, brother. Just really wanted to make sure I was looking at the right thing and understanding the conversation that was happening. :) |
Text-based communication because the lowest bandwidth communication and all that. ;) |
See #1006