Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alphabetize options & update table docs #1192

Closed
wants to merge 7 commits into from
Closed

Alphabetize options & update table docs #1192

wants to merge 7 commits into from

Conversation

joshbruce
Copy link
Member

@joshbruce joshbruce commented Apr 2, 2018 •
edited by styfle
Loading

Marked version: 0.3.19

Markdown flavor: n/a

Description

Adds all configuration options to documentation (though some of the options are not documented by this PR). Adds headerIds option; however, does not implement or test validity yet. headerId implementation will be in a subsequent PR.

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

@joshbruce joshbruce requested a review from styfle April 2, 2018 12:03
@joshbruce joshbruce mentioned this pull request Apr 2, 2018
Merged
6 tasks
@styfle styfle requested a review from UziTech April 2, 2018 23:40
UziTech
UziTech requested changes Apr 3, 2018
View reviewed changes
Copy link
Member

@UziTech UziTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we doing these changes here or #1190?

@styfle
Copy link
Member

styfle commented Apr 3, 2018

Closing in favor of #1190

@styfle styfle closed this Apr 3, 2018
@joshbruce joshbruce deleted the alphabetize-options branch April 4, 2018 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UziTech UziTech UziTech requested changes

@styfle styfle styfle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshbruce @styfle @UziTech