Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typographic switch #573

Closed

Conversation

iamstarkov
Copy link

Hey, I'm using your markdown compiler for a while and want to say thank you for it!

Btw, I’m little obsessed with typography and wrote a bunch of small, full tested and safe to use typographic modules. That’s why I’m wondering will you prefer to delegate typography to 3rd party packages and concentrate marked’s development only on parsing and compiling?

if no, it's fine, I understand. If yes, check out this pull-request and feel free to comment and ask me anything. Will look forward for your response.

PS. My origin idea of this pull-request was that compiler should not be responsible for typography, it should do well parsing and compiling and what do you think?

@iamstarkov
Copy link
Author

hey, hey =) is anybody here? 👻

@iamstarkov
Copy link
Author

polite ping =)

@iamstarkov
Copy link
Author

@chjj is project dead and deprecated?

@JCMais
Copy link

JCMais commented Apr 16, 2015

@matmuchrapna Project is probably dead, given the number of open issues and pull requests.

@chjj
Copy link
Member

chjj commented May 8, 2015

If you want to pull those modules' code into marked, I'll reconsider it, but I really don't want marked to have that many dependencies since it should be used easily in the browser as well.

@chjj chjj closed this May 8, 2015
@iamstarkov
Copy link
Author

All the deps are one-liners, so it’ll be not big deal for browsers, it’s even not small deal

@iamstarkov
Copy link
Author

on the other side, you will have benefit in form of delegating typography to 3rd party plugins

@chjj
Copy link
Member

chjj commented May 8, 2015

@iamstarkov, marked has no dependencies for a reason. It shouldn't require a build for the browser. A lot of people just <script src="raw.github.com/.../marked.js> in their html. There shouldn't be any requires. Changing this would break a lot of pages.

If they're just one-liners that's great. Let's include them inline.

@iamstarkov
Copy link
Author

didn’t about how consumers are using marked, seems reasonable.

If they're just one-liners that's great. Let's include them inline.

okay, it will work. but how to deal with responsibility delegation here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants