Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: test / benchmark / config upgrades #107

Merged
merged 1 commit into from
Jun 1, 2022
Merged

Conversation

DylanPiercey
Copy link
Contributor

Description

  • Switches from esbuild-register to tsx
  • Switches from benchmark.js to mitata
  • Dev deps upgrades
  • Refactor / simplify the benchmark script
  • Switch build/bench scripts to use native es modules (.mts) for top level await.

Motivation and Context

Screenshots (if appropriate):

Checklist:

  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

@changeset-bot
Copy link

changeset-bot bot commented May 19, 2022

⚠️ No Changeset found

Latest commit: b9a4a91

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented May 19, 2022

Codecov Report

Merging #107 (96b6e15) into main (2b6bcbd) will decrease coverage by 1.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #107      +/-   ##
==========================================
- Coverage   94.46%   93.45%   -1.02%     
==========================================
  Files          26       26              
  Lines        1066      733     -333     
  Branches      255      244      -11     
==========================================
- Hits         1007      685     -322     
+ Misses         39       32       -7     
+ Partials       20       16       -4     
Impacted Files Coverage Δ
src/states/JS_COMMENT_LINE.ts 71.42% <0.00%> (-6.35%) ⬇️
src/states/CDATA.ts 90.00% <0.00%> (-3.34%) ⬇️
src/core/Parser.ts 91.30% <0.00%> (-2.73%) ⬇️
src/states/HTML_CONTENT.ts 96.15% <0.00%> (-1.85%) ⬇️
src/states/HTML_COMMENT.ts 90.00% <0.00%> (-1.67%) ⬇️
src/states/OPEN_TAG.ts 94.57% <0.00%> (-1.26%) ⬇️
src/states/EXPRESSION.ts 90.10% <0.00%> (-0.98%) ⬇️
src/states/ATTRIBUTE.ts 95.16% <0.00%> (-0.59%) ⬇️
src/states/CONCISE_HTML_CONTENT.ts 91.48% <0.00%> (-0.58%) ⬇️
src/states/DTD.ts 100.00% <0.00%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b6bcbd...96b6e15. Read the comment docs.

@DylanPiercey DylanPiercey force-pushed the config-improvement branch 3 times, most recently from 3a5c5c5 to 96b6e15 Compare May 23, 2022 22:13
@DylanPiercey DylanPiercey merged commit 5906367 into main Jun 1, 2022
@DylanPiercey DylanPiercey deleted the config-improvement branch June 1, 2022 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant