Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: comment in scriptlet #178

Merged
merged 3 commits into from
Feb 20, 2025
Merged

fix: comment in scriptlet #178

merged 3 commits into from
Feb 20, 2025

Conversation

LuLaValva
Copy link
Member

Description

When a comment inside a scriptlet was terminated with an operator, the parser processed the next line as a part of its statement.

Minimal repro:

$ // +
some-concise-tag

@LuLaValva LuLaValva self-assigned this Feb 13, 2025
Copy link

changeset-bot bot commented Feb 13, 2025

🦋 Changeset detected

Latest commit: b82de05

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
htmljs-parser Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@LuLaValva
Copy link
Member Author

Bonus change: bump CI version (drop 16, add 22)

@LuLaValva LuLaValva merged commit 06f4716 into main Feb 20, 2025
9 checks passed
@LuLaValva LuLaValva deleted the scriptlet-comment branch February 20, 2025 01:26
@github-actions github-actions bot mentioned this pull request Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant