Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to using extracted jsdom-context-require #1071

Merged
merged 3 commits into from
Jun 28, 2018

Conversation

mlrawlings
Copy link
Member

@mlrawlings mlrawlings commented Jun 27, 2018

Description

test/__utils__/create-module-context.js
test/__utils__/create-jsdom-module-context.js
jsdom-context-require

Checklist:

  • My code follows the code style of this project.
  • I have updated/added documentation affected by my changes.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Disclaimer: Contributions via GitHub pull requests are gladly accepted from their original author. Along with any pull requests, please state that the contribution is your original work and that you license the work to the project under the project's open source license. Whether or not you state this explicitly, by submitting any copyrighted material via pull request, email, or other means you agree to license the material under the project's open source license and warrant that you have the legal authority to do so.

@codecov
Copy link

codecov bot commented Jun 27, 2018

Codecov Report

Merging #1071 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1071      +/-   ##
==========================================
+ Coverage   90.51%   90.52%   +<.01%     
==========================================
  Files         305      305              
  Lines       11644    11644              
==========================================
+ Hits        10540    10541       +1     
+ Misses       1104     1103       -1
Impacted Files Coverage Δ
src/morphdom/specialElHandlers.js 87.87% <0%> (+3.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47e2dfe...5729a7e. Read the comment docs.

@coveralls
Copy link

coveralls commented Jun 28, 2018

Coverage Status

Coverage increased (+90.5%) to 90.527% when pulling 5729a7e on jsdom-context-require into 47e2dfe on master.

@mlrawlings mlrawlings merged commit 1e4c5ce into master Jun 28, 2018
@mlrawlings mlrawlings deleted the jsdom-context-require branch July 3, 2018 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants