Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement livereload support #430

Closed
artmouse opened this issue Mar 21, 2021 · 7 comments
Closed

Implement livereload support #430

artmouse opened this issue Mar 21, 2021 · 7 comments

Comments

@artmouse
Copy link

artmouse commented Mar 21, 2021 •
edited
Loading

Anyone has experience in running liveload for this docker?
@artmouse artmouse reopened this Mar 30, 2021
@artmouse
Copy link
Author

artmouse commented Mar 30, 2021 •
edited
Loading

I'm rebuild php image. Add in dockerfile: "EXPOSE 9001 35729" and livereload work, but xdebug not working...

@markshust
Copy link
Owner

This is more of a question, rather than an issue. I'd recommend to open up a Discussion instead of an Issue.

@markshust markshust reopened this Sep 13, 2022
@markshust
Copy link
Owner

This was discussed in #496 and will be implemented momentarily.

@markshust markshust changed the title How to run liveload inside a container? Implement livereload Sep 13, 2022
@markshust markshust changed the title Implement livereload Implement livereload support Sep 13, 2022
markshust added a commit that referenced this issue Sep 13, 2022
@markshust
Implement livereload support #430
c5e74aa
@artmouse
Copy link
Author

Very tricky

markshust added a commit that referenced this issue Sep 13, 2022
@markshust
Documentation and build image for Grunt + LiveReload support #430
fc9c758
@artmouse
Copy link
Author

Why not just open the required port in yml and run the "npm install livereload" command??

@markshust
Copy link
Owner

@artmouse no need, grunt watch automatically spawns off the livereload server, so it's already installed.

It's all set and documented at https://github.com/markshust/docker-magento#grunt--livereload-for-frontend-development

Just ran through the documentation with a fresh site install, went really smooth!

@artmouse
Copy link
Author

#635

h3xx pushed a commit to h3xx/docker-magento that referenced this issue Nov 28, 2022
@markshust @h3xx
Documentation and build image for Grunt + LiveReload support markshus…
790a0b7 
…t#430
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@markshust @artmouse