Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rsync to PHP images for Deployer support #1163

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

gbobts
Copy link

@gbobts gbobts commented May 27, 2024

Hello,
Would you consider adding rsync ?

Copy link

what-the-diff bot commented May 27, 2024

PR Summary

  • Added 'rsync' to Dockerfiles for specific PHP versions
    The Dockerfiles, the scripts that mass-produce reusable images for our application running on PHP 8.1, 8.2, and 8.3, now include a package called 'rsync'. This allows efficient and quicker data copying and synchronization within our application's environment.

@akosglue
Copy link

"potentially benefiting the workflows that use this image" -> an example is deployer's upload: https://github.com/deployphp/deployer/blob/682ff2171d115bf699839852079832ad26534b8e/src/functions.php#L582

(when building magento with this image and using artifact deploy)

@markshust
Copy link
Owner

@gbobts thanks for the link and mention of deployer, that sold me. I also made the update to the PHP 8.1 and 8.2 images. I'll be rebuilding all of these images very shortly in a new build, as it's been a while since they had an update. Appreciate it!

@markshust markshust changed the title Added rsync Add rsync to PHP images for Deployer support Nov 13, 2024
@markshust markshust merged commit e96a217 into markshust:release/next Nov 13, 2024
@markshust markshust mentioned this pull request Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants