Add checker for docker-compose up #256
Conversation
rangerz
force-pushed
the
start
branch
2 times, most recently
from
cc788ba to
2bbb79a
Compare
|
It rebased to master and merged to one commit |
|
@rangerz I apologize for not testing and merging this in already, it must have fell by the wayside. I'll test this and try to get it in very soon. |
| IS_VALID=false | ||
| fi | ||
| done | ||
| [ $IS_VALID = false ] && echo "Failed to start docker for missing volume files" && exit |
There was a problem hiding this comment.
instead of using the IS_VALID variable, I think we can just move this echo/exit line up to line 36 and remove any references to IS_VALID?
There was a problem hiding this comment.
Never mind, just noticed that every file is output to the user first, and then the script should exit. This is wonderful and works great!!
|
@rangerz thank you so much for this, this solves a lot of problems we've been having with those new to this project not properly having files in place for docker to start, causing the empty folder issue. Added a couple comments on the script. Merging it in! THANKS AGAIN!! |
bin/start. Avoiding to generate useless empty folder when there is a lack of volume files. ex:./src/composer.json,./src/composer.lock, and./src/nginx.conf.sample