Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ps command to eliminate exception while running integration tests #292

Merged
merged 1 commit into from
Aug 27, 2020

Conversation

piotrkwiecinski
Copy link
Contributor

@piotrkwiecinski piotrkwiecinski commented Aug 6, 2020

Install ps command on the php container to eliminate while running integration tests:

Fatal error: Uncaught Exception: sh: 1: tasklist.exe: not found in /var/www/html/vendor/magento/framework/Shell.php:63

It's not a fault of the memory check command in magento core. It's more a workaround for now if you're happy to merge.
Reference in core: https://github.com/magento/magento2/blob/2.4-develop/dev/tests/integration/framework/Magento/TestFramework/Helper/Memory.php#L49-L61

I hope to have some time next week to see if I can fix that in core. Anyway it'll take some time to be released even if fix is merged.

ps can also be installed manually using:

bin/root apt update
bin/root apt install procps

@markshust
Copy link
Owner

Thanks! I saw no reason to not merge this in. I'll rebuild the images shortly.

@markshust markshust merged commit b172d03 into markshust:master Aug 27, 2020
@piotrkwiecinski piotrkwiecinski deleted the ps-command branch August 28, 2020 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants