-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add setup-domain-multistore script #697
base: master
Are you sure you want to change the base?
Add setup-domain-multistore script #697
Conversation
Another general way to execute command in the container, ex: PHP
|
@rangerz I could then do this |
Remove redundant code
@TerrorSquad Good, it's simpler ! But I think Be replaced by common bash command
|
@rangerz I've refactored the code to be in line with your example. |
Is it possible for you to update the readme with instructions on how to use this? Perhaps we can also make the config files contain "multistore" in the filenames, so it is apparent these are only intended for multistore setups? |
Hi @markshust I'll update it later today or tomorrow. Did you have the time to test it out? |
Hi @markshust I've updated the readme as well as the names of nginx config files. Since I am working on Linux and don't have a mac I wasn't able to test this out on a mac. Hopefully, it will work the same. |
@TerrorSquad sorry it took so long for me to get back to this. I just ran shellcheck and it appears to be complaining about a few things. Can you take a look?
|
@markshust it should be all good now. |
Appreciate it. I'm currently re-building the PHP images for NodeJS/NPM support, but will circle back around right after to actually test out this PR against those images, then make a subsequent release if all looks good. |
|
Can you guys test this out and possible merge if it's working correctly? |
@TerrorSquad wow it's been a while since I looked at this one. I don't have time this week due to holidays and etc., but I'll try to circle back in a couple weeks unless someone else wants to test this all out. |
I've added a number of files that would allow implementing this script. I think this is a bit rough, so please suggest improvements.
The idea is to first set up a project locally by following the README file. Once the project is up you should do the following steps:
bin/setup-domain-multistore
scriptdocker-compose.linux.yml
fileapp
servicesudo bin/add-base-urls-to-hosts
Notes:
config/nginx/nginx.conf.sample
) and I've added theconfig/nginx/default.conf
file (contents taken from dev docs).- To fetch the data fromstore
table I added a small SQL file that defines the JSON_ARRAYAGG function. The reason for that is: in some older mysql/mariadb versions the function is not available.-store
data is later parsed withjq
in helper scripts (INTRODUCES jq as a dependency)I usedjq
mainly because I wanted a json structure that I could work with in the bash scripts.Resolves #696