Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup script is divided to 2 parts #874

Merged
merged 1 commit into from
Mar 11, 2023
Merged

Setup script is divided to 2 parts #874

merged 1 commit into from
Mar 11, 2023

Conversation

mucan54
Copy link
Contributor

@mucan54 mucan54 commented Mar 6, 2023

Sometimes we just need to run bin/magento setup:install script, so maybe it can be a better approach to divide the setup script to can use the setup-install command alone.

@what-the-diff
Copy link

what-the-diff bot commented Mar 6, 2023

  • The setup script was refactored to call a new bin/setup-install script.
  • This is done so that the environment variables can be sourced in one place, and not duplicated across multiple scripts (bin/setup & bin/magento).
  • A message has been added to inform users of what's happening during installation: "Running Magento setup:install..."

@markshust
Copy link
Owner

I like this update as it just makes everything more simple! All good, appreciate it!! 👍

@markshust markshust merged commit b1dcfa4 into markshust:master Mar 11, 2023
@what-the-diff what-the-diff bot mentioned this pull request Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants