Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move selenium service & configuration to compose.dev.yaml #913

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

piotrkwiecinski
Copy link
Contributor

selenium configuration sits in compose.yaml instead of compose.dev.yaml

Closes #867

selenium configuration sits in compose.yaml instead of compose.dev.yaml
@what-the-diff
Copy link

what-the-diff bot commented Apr 20, 2023

PR Summary

  • Updated File Reference in MFTF Setup Instructions
    The instructions now reference compose.yaml instead of compose.dev.yaml for better clarity when setting up the Flawed Model Turing Framework (MFTF).

  • Corrected Step 2 Reference for Updating extra_host Values
    The second step now corrects refers to compose.yaml instead of compose.dev.yaml, when updating the extra_host values in the setup process. This makes it more user friendly and prevents confusion during setup.

@markshust
Copy link
Owner

I'm going to reopen this one as well -- the Selenium config should live in the compose.dev.yaml file.

@markshust markshust reopened this Jan 21, 2025
@markshust markshust changed the title update mftf section in readme Move selenium service & configuration to compose.dev.yaml Jan 21, 2025
@piotrkwiecinski
Copy link
Contributor Author

This PR modifies documentation as currently selenium definition is located here https://github.com/markshust/docker-magento/blob/release/next/compose/compose.yaml#L138-L143

To my PR should be closed and code should be moved to compose.dev.yaml file instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't enable Selenium in compose.dev.yaml file
2 participants