email: Use noreply@ instead of ghost@ to simplify and avoid confusion

refs TryGhost#17922 refs https://forum.ghost.org/t/staff-new-sign-ups-email-notifications-has-a-wrong-from-email-address/40671
markstos · Sep 4, 2023 · ec2fda0 · ec2fda0
1 parent 5e3470a
commit ec2fda0
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/ghost/core/core/server/data/schema/fixtures/fixtures.json b/ghost/core/core/server/data/schema/fixtures/fixtures.json
@@ -720,7 +720,7 @@
                 {
                     "id": 1,
                     "name": "Ghost",
-                    "email": "ghost@example.com",
+                    "email": "noreply@example.com",
                     "status": "inactive",
                     "free_member_signup_notification": true,
                     "paid_subscription_started_notification": true,

diff --git a/ghost/core/core/server/services/invites/Invites.js b/ghost/core/core/server/services/invites/Invites.js
@@ -52,7 +52,7 @@ class Invites {
                 } else {
                     emailData = {
                         blogName: this.settingsCache.get('title'),
-                        invitedByEmail: `ghost@${this.settingsHelpers.getDefaultEmailDomain()}`,
+                        invitedByEmail: `noreply@${this.settingsHelpers.getDefaultEmailDomain()}`,
                         resetLink: this.urlUtils.urlJoin(adminUrl, 'signup', security.url.encodeBase64(invite.get('token')), '/'),
                         recipientEmail: invite.get('email')
                     };

diff --git a/ghost/core/test/utils/fixtures/fixtures.json b/ghost/core/test/utils/fixtures/fixtures.json
@@ -720,7 +720,7 @@
                 {
                     "id": 1,
                     "name": "Ghost",
-                    "email": "ghost@example.com",
+                    "email": "noreply@example.com",
                     "free_member_signup_notification": true,
                     "paid_subscription_started_notificaton": true,
                     "paid_subscription_canceled_notification": false,

diff --git a/ghost/staff-service/lib/StaffServiceEmails.js b/ghost/staff-service/lib/StaffServiceEmails.js
@@ -445,7 +445,7 @@ class StaffServiceEmails {
     }
 
     get fromEmailAddress() {
-        return `ghost@${this.defaultEmailDomain}`;
+        return `noreply@${this.defaultEmailDomain}`;
     }
 
     extractInitials(name = '') {

diff --git a/ghost/staff-service/test/staff-service.test.js b/ghost/staff-service/test/staff-service.test.js
@@ -18,7 +18,7 @@ function testCommonMailData({mailStub, getEmailAlertUsersStub}) {
 
     // has right from/to address
     mailStub.calledWith(sinon.match({
-        from: 'ghost@ghost.example',
+        from: 'noreply@ghost.example',
         to: '[email protected]'
     })).should.be.true();