changing the existing weapon instead of creating a new one

[BestAwperEver]

Hotfix for the recent internal changes.

Without it we have many players with unknown weapons. Before the internal changes we had an actual array with fixed memory layout so every entity ID had a fixed pointer to an equipment, which doesn't hold now, so when we first have a player binded (with unknown weapons at the moment) and then we bind their weapons, the pointers we have in player's rawWeapons still point to the unknown weapons.

[codecov]

Codecov Report

Merging #197 into master will not change coverage by %.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #197   +/-   ##
=======================================
  Coverage   92.50%   92.50%           
=======================================
  Files          28       28           
  Lines        2655     2655           
=======================================
  Hits         2456     2456           
  Misses        148      148           
  Partials       51       51           

Impacted Files	Coverage Δ
datatables.go	98.97% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3634f34...7014971. Read the comment docs.

[BestAwperEver]

Why does Travis fail, exactly? Locally I ran regression tests on both ParserWarn and unassert variants and it seems to be OK, and also Travis passed here with ParserWarn as well

[markus-wa]

travis failed on an unassert condition. to test these you have to run the tests with -tags unassert_panic (or run test scripts from ./bin/ which should do it automatically).

I did some debugging and took the liberty of pushing a fix to your branch: 7c21a15

fingers crossed this works.

[markus-wa]

I removed the comment Something is clearly wrong here as it seems to be a common case.

I accidentially also removed the other one, oops. will re-add it in a sec

[markus-wa]

Merged - many thanks as always @BestAwperEver 🙌

v1.9.1 is out as well: https://github.com/markus-wa/demoinfocs-golang/releases/tag/v1.9.1

[BestAwperEver]

No problem, was my mistake in the first place 😃

[markus-wa]

was my mistake in the first place

Only because I forced you to replace my ugly array with a map 😅