Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: fix events.BombPlantBegin.Site being off for new demos #313

Merged
merged 2 commits into from
Oct 17, 2021

Conversation

markus-wa
Copy link
Owner

old demos had the site attirbute as short, new demos seem to have it as a long

old demos had the site attirbute as short, new demos seem to have it as a long
@codecov
Copy link

codecov bot commented Oct 16, 2021

Codecov Report

Merging #313 (8e787ce) into master (041838a) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #313      +/-   ##
==========================================
+ Coverage   92.56%   92.58%   +0.01%     
==========================================
  Files          30       30              
  Lines        3012     3019       +7     
==========================================
+ Hits         2788     2795       +7     
  Misses        169      169              
  Partials       55       55              
Impacted Files Coverage Δ
pkg/demoinfocs/game_events.go 94.38% <100.00%> (+0.05%) ⬆️
pkg/demoinfocs/parser.go 81.14% <100.00%> (+0.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 041838a...8e787ce. Read the comment docs.

@markus-wa markus-wa merged commit b2c45b1 into master Oct 17, 2021
@markus-wa markus-wa deleted the fix-bombevent-site-long-vs-short branch October 17, 2021 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant