Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance improvements #454

Merged
merged 2 commits into from
Oct 31, 2023
Merged

Performance improvements #454

merged 2 commits into from
Oct 31, 2023

Conversation

markus-wa
Copy link
Owner

No description provided.

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (aa1b925) 80.37% compared to head (051921a) 80.38%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #454      +/-   ##
==========================================
+ Coverage   80.37%   80.38%   +0.01%     
==========================================
  Files          47       47              
  Lines        6251     6257       +6     
==========================================
+ Hits         5024     5030       +6     
  Misses       1018     1018              
  Partials      209      209              
Files Coverage Δ
pkg/demoinfocs/sendtables2/field_path.go 80.60% <100.00%> (-0.15%) ⬇️
pkg/demoinfocs/sendtables2/quantizedfloat.go 64.16% <100.00%> (-0.30%) ⬇️
pkg/demoinfocs/sendtables2/entity.go 60.57% <90.90%> (+1.17%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akiver
Copy link
Collaborator

akiver commented Oct 31, 2023

Some nice perf improvements, thanks!

Demo size Before (s) After (s) Diff (%)
111MB 4.0033006 3.6443069 9.0
180MB 7.0180244 6.4299505 8.41
221MB 8.0438853 7.3611396 8.46

@markus-wa markus-wa merged commit 8bf8a71 into master Oct 31, 2023
@markus-wa markus-wa deleted the perf-improvements branch October 31, 2023 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants