fix: possible invalid weapon in kill events #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following #490. - It's not always a suffix - it can be a prefix. - The suffix/prefix is not the killer's name but the words `vip` or `default` (there may be others). - The team's name may also be part of the suffix/prefix Noticed with demos coming from akiver/cs-demo-manager#727. Example with this one https://mega.nz/file/LZFlhATB#aCO-g1hoGohndAKXJVUHzLCcbyzH-n7cGi9ZWO5UdSM. Weapon's name from game events: ``` 5e_vip_usp_silencer 5e_default_deagle 5e_vip_xm1014 5e_default_mp9 5e_default_galilar 5e_vip_m4a1_silencer 5e_vip_ak47 ```
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #496 +/- ##
=======================================
Coverage 80.67% 80.67%
=======================================
Files 47 47
Lines 6338 6338
=======================================
Hits 5113 5113
Misses 1015 1015
Partials 210 210 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #490.
vipordefault(there may be others).Noticed with demos coming from akiver/cs-demo-manager#727.
Example with this one https://mega.nz/file/LZFlhATB#aCO-g1hoGohndAKXJVUHzLCcbyzH-n7cGi9ZWO5UdSM.
Weapon's name from game events: