Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Something is off with Safari #12

Closed
mgatelabs opened this issue Mar 7, 2022 · 4 comments
Closed

Something is off with Safari #12

mgatelabs opened this issue Mar 7, 2022 · 4 comments

Comments

@mgatelabs
Copy link

mgatelabs commented Mar 7, 2022

I'm trying to figure out what is going on with my app and safari. I was able to trace it down to THREE.Interactive as the part which causes the crash. The crash only tells me "SyntaxError: Left hand side of operator '=' must be a reference." and something about promiseReactionJob, but no other details, no line number.

What I tried:

  • I've played with my code and removed Three.Interactive, and it starts working.
  • Tried to isolate things and only reference classes like this console.log(InteractionManager); and it still fails.
  • I included the main ts file from Three.Interactive and removed the dependency and it works.
  • Development builds are working, only production suffers, so should be something with the optimizer

So it feels like something is off when the dependency is used, since if I natively bring in the class and use it, everything is fine. I know THREE had a similar issue a few years ago from this page: angular/angular-cli#21107

Repo: https://github.com/mgatelabs/GenshinSolvers
Live: https://mgatelabs.github.io/GenshinSolvers/ (This will have the internal version of Three.Interactive for now)

Also, I tried the sample apps linked to the Readme and in safari they are working, so unsure what is going on.

@markuslerner
Copy link
Owner

Hi, please try using version v.1.3.0 and let me know, if the problem still persists.

@mgatelabs
Copy link
Author

I'll give it a try, thanks

@mgatelabs
Copy link
Author

Tried it locally, and it seems to be working, Nice!

@markuslerner
Copy link
Owner

Cool, thank you for letting me know, @mgatelabs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants