Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just noticed that I forgot to exclude three.js from the built output. This made it significantly larger than it should have been.
This fixes that by marking three.js as an external dependency. And it moves it to peerDependencies.
However, it introduces a new problem. The built file now starts with the following, since it's
In Node.js or with any modern build tool, this works quite fine. "three" is specified in the package.json, and thus, Node/the build tool knows what to do and where to find it (
node_modules
).However, web browsers don't. This effectively breaks the examples, since the examples don't go through a compile step.
There is a really nice proposal called "import maps", which solves that. It lets you specify what dependencies there are and how to get them. And Chrome already supports them. But other browsers aren't quite that far yet.