Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bitrate parsing for cross-platform environment #140

Merged
merged 1 commit into from
Mar 9, 2024

Conversation

ktrzcinx
Copy link

@ktrzcinx ktrzcinx commented May 5, 2021

Previous version of parsing was unable to get valid content
eg. when output ends with '\r' character what is possible
in cross platform environment. New parser version is resistant
for any line ending.
Moreover parser is insensistive for prefix letter size, see bug:
#119 (comment)

Signed-off-by: Karol Trzcinski [email protected]

Previous version of parsing was unable to get valid content
eg. when `output` ends with '\r' character what is possible
in cross platform environment. New parser version is resistant
for any line ending.
Moreover parser is insensistive for prefix letter size, see bug:
marl#119 (comment)

Signed-off-by: Karol Trzcinski <[email protected]>
@lostanlen
Copy link
Member

Sounds good, many thanks.
I don't understand the logic of elif greek_index, could you please explain?

@ktrzcinx
Copy link
Author

ktrzcinx commented May 6, 2021

I don't understand the logic of elif greek_index, could you please explain?

greek_index it's array of found greek letter indexes in output.upper(), so when any letters has been found then if greek_index will be True, otherwise False (for empty array).

@lostanlen
Copy link
Member

( ... a few moment later ...)
Hello again @ktrzcinx. With permission from @rabitt I am taking over the maintenance of pysox and prepare a new release (v1.5) on PyPI. I have push access on this repository.

I am keen to merge you PR. Other people have reported a \r bug on Windows: #159

Can you please write a test which triggers this bug on Windows and show that your PR solves it?

@nullptr-0
Copy link
Contributor

( ... a few moment later ...) Hello again @ktrzcinx. With permission from @rabitt I am taking over the maintenance of pysox and prepare a new release (v1.5) on PyPI. I have push access on this repository.

I am keen to merge you PR. Other people have reported a \r bug on Windows: #159

Can you please write a test which triggers this bug on Windows and show that your PR solves it?

test is in #163

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants