Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for 3rd party index #155

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Conversation

mangas
Copy link
Contributor

@mangas mangas commented Dec 13, 2024

Implements #134

  • Add flag to override the index to fetch the tarball link from.

@mangas mangas marked this pull request as ready for review December 13, 2024 20:50
@mangas
Copy link
Contributor Author

mangas commented Dec 13, 2024

The cosmetic changes were done by zig fmt on save, if needed I can remove them.

@mangas mangas mentioned this pull request Dec 13, 2024
@marler8997
Copy link
Owner

thanks for the contribution. I went ahead and ran zig fmt and pushed to master. Do you mind rebasing and/or reworking the change off of master so I don't have to wade through the formatting changes?

@mangas
Copy link
Contributor Author

mangas commented Dec 16, 2024

There are still some small cosmetic changes but seems a lot easier to parse now. Let me know if this is close enough otherwise I can try to make the changes and turn off the formatting

@marler8997 marler8997 merged commit 570255f into marler8997:master Dec 16, 2024
3 checks passed
@marler8997
Copy link
Owner

such a simple change/enhancement, I'm just going to merge this as is. Would be nice to add a test but can be done later.

@mangas
Copy link
Contributor Author

mangas commented Dec 16, 2024

I'll have a look at the tests and see if I can add one that uses this flag

@mangas mangas deleted the add-index-flag branch December 16, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants