Refactor Remote Init Script #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djhi
commented
Dec 2, 2024
|
|
||
| return projectRef; | ||
| async function waitForProjectToBeReady({ projectRef }) { | ||
| console.log('Waiting for project to be ready...'); |
There was a problem hiding this comment.
Not a debug log. The wait can be long so we display this message to let users know we're not stuck
fzaninotto
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #75
As expected, the previous version of the script wasn't reliable as it used the human readable output of the Supabase CLI.
Solution
Use the new
outputCLI argument allowing us to get a JSON output.How To Test
Run the
make supabase-remote-init