Skip to content

Commit

Permalink
Bump development Node.js to v18 LTS
Browse files Browse the repository at this point in the history
  • Loading branch information
yhatt committed Nov 20, 2022
1 parent 7e58d83 commit 4d6e808
Show file tree
Hide file tree
Showing 4 changed files with 20 additions and 6 deletions.
17 changes: 15 additions & 2 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ executors:
default: false
version:
type: string
default: '16.16' # Specify LTS major and minor for development
default: '18.12' # Specify LTS major and minor for development
docker:
- image: cimg/node:<< parameters.version >><<# parameters.browser >>-browsers<</ parameters.browser >>
working_directory: ~/marp-cli
Expand Down Expand Up @@ -182,12 +182,21 @@ jobs:
executor:
name: node
browser: true
version: '14.19'
version: '14.21'
steps:
- test:
browser: true

test-node16:
executor:
name: node
browser: true
version: '16.18'
steps:
- test:
browser: true

test-node18:
executor:
name: node
browser: true
Expand Down Expand Up @@ -230,12 +239,16 @@ workflows:
- test-node16:
requires:
- audit
- test-node18:
requires:
- audit

# Docker (latest)
- docker-build-latest:
requires:
- test-node14
- test-node16
- test-node18
filters:
branches:
only: main
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/test-win.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,9 @@ jobs:
fail-fast: false
matrix:
node-version:
- '^14.18.1'
- '16.16.0'
- '^14.21.1'
- '^16.18.1'
- '18.12.1'

steps:
# - name: Output concurrency group
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
16.16.0
18.12.1
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:16.16.0-alpine
FROM node:16.18.1-alpine
LABEL maintainer "Marp team"

RUN apk update && apk upgrade && \
Expand Down

0 comments on commit 4d6e808

Please sign in to comment.