Improve Puppetter utility based on several reports #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User can enable extensions while converting in Puppeteer via CHROME_ENABLE_EXTENSIONS environment value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved Puppetter utility based on several reports.
async/awaitkeyword fromgeneratePuppeteerLaunchArgs().CLIErrorwith helpful message if the executable Chrome path cannot find out. (Emit better error message when there is not a compatible browser #220)SET CHROME_ENABLE_EXTENSIONS=1before executing Marp CLI can enable extensions while converting Markdown.Closes #220. #231 needs more reports about this change.