Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal: Prepare new browser manager interface and recreated finder #595

Merged
merged 13 commits into from
Sep 23, 2024

Conversation

yhatt
Copy link
Member

@yhatt yhatt commented Sep 22, 2024

Related: #565

Note

This change should not introduce any major change of the behavior into current Marp CLI.

This PR prepares new browser manager interface classes and the recreated browser finders including Firefox support.

await findBrowser()
/*
{
  path: '/Applications/Google Chrome.app/Contents/MacOS/Google Chrome',
  acceptedBrowsers: [
    [class ChromeBrowser extends Browser] {
      kind: 'chrome',
      protocol: 'webdriver-bidi'
    },
    [class ChromeCdpBrowser extends Browser] {
      kind: 'chrome',
      protocol: 'cdp'
    }
  ]
}
*/

findBrowser() returns Promise to resolve automatically detected browser path and its supported browser classes. In next major release v4, we are planning it would be used for converting Markdown (WebDriver BiDi) and launching preview window (CDP).

@yhatt yhatt mentioned this pull request Sep 22, 2024
@yhatt yhatt merged commit c727e9c into main Sep 23, 2024
13 checks passed
@yhatt yhatt deleted the prepare-new-browser-finder branch September 23, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant