-
-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Node and dependent packages to the latest #77
Changes from all commits
5f49564
ad47c08
2aedb03
5733b1e
473cca8
cec6b62
bd04221
99dd589
c832795
d089e6f
9d58395
c37085d
4088f1f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
v10.15.1 | ||
v10.15.3 |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -257,24 +257,14 @@ export class Converter { | |
|
||
private static async runBrowser() { | ||
if (!Converter.browser) { | ||
// Fix the rendered position of elements in <foreignObject> | ||
// See: https://bugs.chromium.org/p/chromium/issues/detail?id=467484 | ||
const args = ['--enable-blink-gen-property-trees'] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Puppeteer v1.13.0 no longer works BGPT feature. It seems to have no critical problems while rendering PDF and images. |
||
|
||
let finder: () => string[] = require('is-wsl') | ||
? chromeFinder.wsl | ||
: chromeFinder[process.platform] | ||
|
||
if (process.env.IS_DOCKER || process.env.CI) | ||
args.push('--disable-dev-shm-usage') | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Puppeteer already has |
||
|
||
if (process.env.IS_DOCKER) { | ||
args.push('--no-sandbox') | ||
finder = () => ['/usr/bin/chromium-browser'] | ||
} | ||
const finder: () => string[] = (() => { | ||
if (process.env.IS_DOCKER) return () => ['/usr/bin/chromium-browser'] | ||
if (require('is-wsl')) return chromeFinder.wsl | ||
return chromeFinder[process.platform] | ||
})() | ||
|
||
Converter.browser = await puppeteer.launch({ | ||
args, | ||
args: process.env.IS_DOCKER ? ['--no-sandbox'] : [], | ||
executablePath: finder ? finder()[0] : undefined, | ||
}) | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add workaround for broken Chrome 73. We have to use Chromium supported by Puppeteer (Chromium 74) within image.
We have confirmed to work conversion in Chrome 73 with out of container (Windows/macOS/Linux).