Apply workaround for vanished <marp-auto-scaling> component in Chrome 105+ #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found sometimes the content of
<marp-auto-scaling>component may not render in the first rendering of Chrome/Chromium 105 beta and later. Computing DOM positions is correct but contents are not painted at the first time.Because of this problem, yhatt/marp-cli-example is temporally using Chromium 104 provided by the old Puppeteer, instead of the latest Chromium 105.
yhatt/marp-cli-example@b246940
I don't know the clear reason why, but I guess nested shadow DOMs may prevent painting the content of SVG. Flushing
<svg>element by changingdisplaystyle will render. Thus, I've patched to<marp-auto-scaling>component to flushdisplaystyle on mounted.By adopting the updated component, I've confirmed to fix vanished auto-scaling content when exporting image by Marp CLI.