Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider to make toolbar icon monochrome #193

Closed
yhatt opened this issue Jan 31, 2021 · 0 comments · Fixed by #196
Closed

Consider to make toolbar icon monochrome #193

yhatt opened this issue Jan 31, 2021 · 0 comments · Fixed by #196

Comments

@yhatt
Copy link
Member

yhatt commented Jan 31, 2021

According to VS Code extension guideline recently published (https://code.visualstudio.com/api/references/extension-guidelines), Marp's colored icon is going against the guideline of editor actions clearly.

❌ Don't

  • Add more than one icon
  • Add custom colors
  • Use emojis

I've already made the variation of icon in #105, and we have taken the colored icon because it may make finding out Marp icon difficult in the drastic case of changing from the brand logo to monochrome outline. But now we can apply step-by-step updation of the outline from colored to monotone.

Current Monochromed outline
Dark theme
Light theme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant