Update toolbar icon to match VS Code outline style #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to match style of added toolbar icon to VS Code's outline style (microsoft/vscode-icons).
A previous colored icon helps to make attention user. However, it was too much standing out from the other toolbar buttons. By matching style, we would get a seamless experience familiar with VS Code.
It looks like Marpit rather than Marp, but I don't think it loses a brand because we are going to keep using colored icon as the extension icon. In fact, SVG icons for marp-vscode has detailed differences from Marp and Marpit, for matching style to VS Code.
(marp-cli)
(marp-vscode)
Unlike Marpit and an outline icon for Marp CLI, VS Code's outline icon has bevel corners to match vscode-icons style.
My concern is the outline icon with monochrome stroke may make finding out Marp icon difficult. So I also created another version colored with our primary / secondary brand color. We would like to want feedbacks from extension user.
ToDo